Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAybe cleanup the tags and add the narrators as the producers? #18

Closed
dethrophes opened this issue Sep 30, 2017 · 8 comments
Closed

MAybe cleanup the tags and add the narrators as the producers? #18

dethrophes opened this issue Sep 30, 2017 · 8 comments

Comments

@dethrophes
Copy link

I noticed that sometimes the genres etc... can be a bit unclean, it helps to strip, them.
It is also a pretty standard convention to set the producer to the narrator, from what I can see so that probably doesn't hurt either.
e.g.`
metadata.genres.add(series.strip())
for c in narrator.split(','):
metadata.genres.add(c.strip())
metadata.genres.add(genre1.strip())
metadata.genres.add(genre2.strip())

    metadata.producers.clear()
    for c in narrator.split(','):
        metadata.producers.add(c.strip())
    
    # other metadata

`

@macr0dev
Copy link
Owner

I've been thinking about this one, and while I don't completely disagree with the logic of your placement it just doesn't work for one of my goals. One of the things I wanted to be able to do was 'filter' by the narrator. Since you can't filter by Producer, I can't see moving the information to that field.

@dethrophes
Copy link
Author

dethrophes commented Oct 26, 2017 via email

@macr0dev
Copy link
Owner

ooooh. I thought you were talking about moving it. You'd mentioned the genres being 'unclean' and in my mind I interpreted that as 'cluttered'.

I get what you're saying now. Yeah. I'll get that thrown in there in a couple of days.

@macr0dev
Copy link
Owner

heads up.... Audible did a major re-write of their page and broke everything. I've got a new issue started on it already. gonna try to work on it tomorrow and this weekend. Gonna keep notes on it over in that issue.

@macr0dev
Copy link
Owner

macr0dev commented Nov 8, 2017

I was looking at this one the other day, and I couldn't actually find where you were talking about putting them. I don't see a 'producer' entry on the album properties inside plex. Is there some hidden metadata I'm not aware of?

@dethrophes
Copy link
Author

dethrophes commented Nov 9, 2017 via email

@macr0dev
Copy link
Owner

macr0dev commented Nov 9, 2017

OK, but where does it show up in Plex? Between Plex and PlexPy I can't see where that data is displayed anywhere. Is it just being stored in the database somewhere and isn't accessible?

@macr0dev
Copy link
Owner

Cleaning up and closing old issues. Closing./

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants