fix(ping probe): fix crash when host not found

macrat · Apr 30, 2021 · 704ab76 · 704ab76
1 parent 77892b4
commit 704ab76
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/probe/ping.go b/probe/ping.go
@@ -59,6 +59,7 @@ func (p PingProbe) Check(ctx context.Context, r Reporter) {
 			Status:    store.STATUS_UNKNOWN,
 			Message:   err.Error(),
 		})
+		return
 	}
 
 	ping := pingerV4

diff --git a/probe/ping_test.go b/probe/ping_test.go
@@ -22,6 +22,7 @@ func TestPingProbe(t *testing.T) {
 		{"ping:localhost", store.STATUS_HEALTHY, `rtt\(min/avg/max\)=[0-9.]*/[0-9.]*/[0-9.]* send/rcv=4/4`},
 		{"ping:127.0.0.1", store.STATUS_HEALTHY, `rtt\(min/avg/max\)=[0-9.]*/[0-9.]*/[0-9.]* send/rcv=4/4`},
 		{"ping:::1", store.STATUS_HEALTHY, `rtt\(min/avg/max\)=[0-9.]*/[0-9.]*/[0-9.]* send/rcv=4/4`},
+		{"ping:of-course-definitely-no-such-host", store.STATUS_UNKNOWN, `.*`},
 	})
 
 	AssertTimeout(t, "ping:localhost")