Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Standard keywords in make_test_df() #1014

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Conversation

Magnus167
Copy link
Member

The function used start_date and end_date to specify dates, whereas the rest of the package uses start and end (with the notable exception of ms.download)

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1014 (64927df) into develop (889d546) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 64927df differs from pull request most recent head 324f949. Consider uploading reports for the commit 324f949 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1014   +/-   ##
========================================
  Coverage    63.70%   63.70%           
========================================
  Files           45       45           
  Lines         4987     4987           
========================================
  Hits          3177     3177           
  Misses        1810     1810           
Files Coverage Δ
...rosynergy/management/simulate_quantamental_data.py 87.24% <100.00%> (ø)
macrosynergy/panel/linear_composite.py 94.11% <ø> (ø)
macrosynergy/visuals/view.py 57.77% <ø> (ø)

Impacted file tree graph

@Magnus167 Magnus167 merged commit 110db0a into develop Sep 28, 2023
3 checks passed
@Magnus167 Magnus167 deleted the bugfix/make_test_df branch September 28, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants