Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: is_valid_iso_date #1022

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Bugfix: is_valid_iso_date #1022

merged 2 commits into from
Sep 29, 2023

Conversation

Magnus167
Copy link
Member

The function depended on an underlying function (dt.datetime.strptime) to raise a type error when a non-string value was passed. The unittests for the same function has been enhanced.

@Magnus167 Magnus167 requested review from GlennRe9 and CyrusYavariMacro and removed request for GlennRe9 September 29, 2023 14:17
@Magnus167 Magnus167 merged commit 31b8c19 into develop Sep 29, 2023
3 checks passed
@Magnus167 Magnus167 deleted the bugfix/is_valid_iso_date branch September 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants