-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: ticker_df_to_qdf()
utility
#1034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magnus167
changed the title
Feature:
Feature: Oct 6, 2023
ticker_df_to_qdf
utilityticker_df_to_qdf()
utility
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1034 +/- ##
===========================================
+ Coverage 63.76% 64.10% +0.34%
===========================================
Files 45 45
Lines 5003 5051 +48
===========================================
+ Hits 3190 3238 +48
Misses 1813 1813
|
sandresen1
previously approved these changes
Oct 6, 2023
emhbrine
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionality for
ticker_df_to_qdf()
andqdf_to_ticker_df()
.This utility is useful across a lot of calculation functions and is implemented implicitly in various files.
Although it may not yet be optimized, it would make sense to centralize such utils.
This PR also includes utils for
split_ticker()
- to get thecid
orxcat
from a ticker, and convenience functionsget_cid()
andget_xcat()
(overloaded forstr
andList[str]
, usesplit_ticker()
as a backend).