Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: JPMaQSDownloader, downloading generic DQ expressions #1038

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

Magnus167
Copy link
Member

@Magnus167 Magnus167 commented Oct 7, 2023

Closes Issue: #1037

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #1038 (15879ea) into develop (1b14d66) will decrease coverage by 0.16%.
Report is 17 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 15879ea differs from pull request most recent head d247e3f. Consider uploading reports for the commit d247e3f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1038      +/-   ##
===========================================
- Coverage    63.81%   63.66%   -0.16%     
===========================================
  Files           45       45              
  Lines         5008     4998      -10     
===========================================
- Hits          3196     3182      -14     
- Misses        1812     1816       +4     
Files Coverage Δ
macrosynergy/download/jpmaqs.py 81.45% <100.00%> (-0.66%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 merged commit fd37d21 into develop Oct 9, 2023
3 checks passed
@Magnus167 Magnus167 deleted the bugfix/jpmaqs_download_metrics branch October 10, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants