Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: extend correl_matrix to calculate correlation between two sets #1041

Merged
merged 13 commits into from
Oct 12, 2023

Conversation

emhbrine
Copy link
Contributor

@emhbrine emhbrine commented Oct 9, 2023

This PR allows the xcats or cids parameters of the correl_matrix function to take a list containing two lists. In this case, the correlation will be calculated and visualized between these two sets.

If both sets contain a single category, such as xcats = [['XR'], ['CRY']], correlation will be visualized between the cross-sections of these categories. If either set contains more than one category, correlation is visualized between categories.

cross_section_corr
cross_category_corr

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1041 (6dc9291) into develop (d153187) will increase coverage by 0.60%.
Report is 1 commits behind head on develop.
The diff coverage is 60.90%.

❗ Current head 6dc9291 differs from pull request most recent head 1f1fb44. Consider uploading reports for the commit 1f1fb44 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1041      +/-   ##
===========================================
+ Coverage    63.73%   64.34%   +0.60%     
===========================================
  Files           45       45              
  Lines         4997     5043      +46     
===========================================
+ Hits          3185     3245      +60     
+ Misses        1812     1798      -14     
Files Coverage Δ
macrosynergy/panel/view_correlations.py 66.66% <60.90%> (+26.66%) ⬆️

Impacted file tree graph

@emhbrine emhbrine marked this pull request as ready for review October 9, 2023 11:50
Magnus167
Magnus167 previously approved these changes Oct 9, 2023
Copy link
Member

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved @emhbrine's changes

Magnus167
Magnus167 previously approved these changes Oct 11, 2023
Copy link
Member

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @emhbrine 's

@emhbrine emhbrine merged commit 3cd75f1 into develop Oct 12, 2023
3 checks passed
@Magnus167 Magnus167 deleted the feature/extend_view_correlations branch October 12, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants