Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: new class SignalsReturns, complementing SignalReturnRelations #1043

Merged
merged 92 commits into from
Oct 25, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 linked an issue Oct 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1043 (2b61792) into develop (8fa4f30) will increase coverage by 0.72%.
Report is 1 commits behind head on develop.
The diff coverage is 75.25%.

❗ Current head 2b61792 differs from pull request most recent head e1de24f. Consider uploading reports for the commit e1de24f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1043      +/-   ##
===========================================
+ Coverage    64.52%   65.24%   +0.72%     
===========================================
  Files           54       56       +2     
  Lines         5522     5781     +259     
===========================================
+ Hits          3563     3772     +209     
- Misses        1959     2009      +50     
Files Coverage Δ
macrosynergy/signal/__init__.py 100.00% <100.00%> (ø)
macrosynergy/signal/signal_base.py 95.65% <95.65%> (ø)
macrosynergy/signal/signal_return.py 77.77% <82.77%> (+11.92%) ⬆️
macrosynergy/signal/signal_return_relations.py 42.36% <42.36%> (ø)

Impacted file tree graph

@Magnus167 Magnus167 changed the title Feature: Add new class SignalsReturns which is similar to SignalReturnRelations but does not store and calculate statistics upon instantiation Feature: new class SignalsReturns, complementing SignalReturnRelations Oct 9, 2023
@sandresen1 sandresen1 marked this pull request as ready for review October 24, 2023 12:04
@sandresen1 sandresen1 requested review from rsueppel and a team as code owners October 24, 2023 12:04
@sandresen1 sandresen1 merged commit 0e62655 into develop Oct 25, 2023
4 checks passed
@sandresen1 sandresen1 deleted the feature/SignalsReturns branch October 25, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new class: SignalsReturns (complementing SignalReturnRelations)
3 participants