Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Caches dependencies when building #1047

Merged
merged 116 commits into from
Oct 11, 2023
Merged

Conversation

sandresen1
Copy link
Contributor

@sandresen1 sandresen1 commented Oct 9, 2023

On every build, caching should take place to store the pip dependencies so they don't need to be reinstalled each time upon building.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1047 (d153187) into develop (656045a) will increase coverage by 0.08%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head d153187 differs from pull request most recent head faad37b. Consider uploading reports for the commit faad37b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1047      +/-   ##
===========================================
+ Coverage    63.65%   63.73%   +0.08%     
===========================================
  Files           45       45              
  Lines         4997     4997              
===========================================
+ Hits          3181     3185       +4     
+ Misses        1816     1812       -4     

see 1 file with indirect coverage changes

Impacted file tree graph

@sandresen1
Copy link
Contributor Author

Caching seems to work fine and will only install a package if specified in the toml file. But the time taken to retrieve from cache seems to be the same as downloading :(

@sandresen1 sandresen1 changed the title Feature: Caches Dependencies when building Feature: Caches dependencies when building Oct 11, 2023
Magnus167
Magnus167 previously approved these changes Oct 11, 2023
@sandresen1 sandresen1 merged commit 7825f5a into develop Oct 11, 2023
3 checks passed
@Magnus167 Magnus167 deleted the feature/cachingOnBuild branch October 11, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Python environments as GitHub artifacts
3 participants