Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: new panel_cv_scores to return cv scores over a panel #1055

Merged
merged 15 commits into from
Oct 13, 2023

Conversation

rushilg99
Copy link
Contributor

@rushilg99 rushilg99 commented Oct 11, 2023

DO NOT MERGE UNTIL RALPH HAS REVIEWED.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1055 (dcbf231) into develop (9b5520f) will increase coverage by 1.06%.
Report is 1 commits behind head on develop.
The diff coverage is 23.52%.

❗ Current head dcbf231 differs from pull request most recent head 80a6c9d. Consider uploading reports for the commit 80a6c9d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1055      +/-   ##
===========================================
+ Coverage    64.26%   65.33%   +1.06%     
===========================================
  Files           45       45              
  Lines         5043     5083      +40     
===========================================
+ Hits          3241     3321      +80     
+ Misses        1802     1762      -40     
Files Coverage Δ
macrosynergy/learning/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
macrosynergy/learning/panel_timeseries_split.py 31.22% <21.21%> (+31.22%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@rushilg99 rushilg99 requested a review from a team as a code owner October 12, 2023 17:14
@Magnus167 Magnus167 changed the title Feature/sklearn integration Feature: PanelSplitterClass, integrating sklearn Oct 13, 2023
@rushilg99 rushilg99 changed the title Feature: PanelSplitterClass, integrating sklearn Feature: PanelTimeSeriesSplit returns numerical index not multi-index, new panel_cv_scores to return cv scores over a panel Oct 13, 2023
@rushilg99 rushilg99 changed the title Feature: PanelTimeSeriesSplit returns numerical index not multi-index, new panel_cv_scores to return cv scores over a panel Feature: PanelTimeSeriesSplit to return the numerical index not multi-index + new panel_cv_scores to return cv scores over a panel Oct 13, 2023
@rushilg99 rushilg99 changed the title Feature: PanelTimeSeriesSplit to return the numerical index not multi-index + new panel_cv_scores to return cv scores over a panel Feature: new panel_cv_scores to return cv scores over a panel Oct 13, 2023
rsueppel
rsueppel previously approved these changes Oct 13, 2023
@rushilg99 rushilg99 merged commit 8723435 into develop Oct 13, 2023
3 checks passed
@rushilg99 rushilg99 deleted the feature/sklearn_integration branch October 13, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants