Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: view metrics refactor #1056

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

emhbrine
Copy link
Contributor

@emhbrine emhbrine commented Oct 12, 2023

  • Added the Heatmap class in visuals/.
  • The implementation of the view_metrics function was moved into view/metrics.py and now uses the Heatmap class for plotting.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1056 (933b98d) into develop (dcbf231) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 71.31%.

❗ Current head 933b98d differs from pull request most recent head 64ab800. Consider uploading reports for the commit 64ab800 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1056      +/-   ##
===========================================
- Coverage    65.33%   65.32%   -0.02%     
===========================================
  Files           45       48       +3     
  Lines         5083     5133      +50     
===========================================
+ Hits          3321     3353      +32     
- Misses        1762     1780      +18     
Files Coverage Δ
macrosynergy/visuals/__init__.py 100.00% <100.00%> (ø)
macrosynergy/visuals/plotter.py 94.25% <100.00%> (+18.06%) ⬆️
macrosynergy/visuals/view/__init__.py 100.00% <100.00%> (ø)
macrosynergy/management/utils.py 90.62% <92.85%> (+0.17%) ⬆️
macrosynergy/panel/view_metrics.py 35.00% <66.66%> (-50.56%) ⬇️
macrosynergy/visuals/view/timelines.py 60.20% <50.00%> (ø)
macrosynergy/visuals/view/metrics.py 66.66% <66.66%> (ø)
macrosynergy/visuals/heatmap.py 65.45% <65.45%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

@emhbrine emhbrine force-pushed the feature/view_metrics_refactor branch 2 times, most recently from b3aef4f to 69eee80 Compare October 13, 2023 16:49
@emhbrine emhbrine force-pushed the feature/view_metrics_refactor branch from 69eee80 to 95b5b5f Compare October 13, 2023 16:52
@emhbrine emhbrine force-pushed the feature/view_metrics_refactor branch from 0654719 to 64ab800 Compare October 13, 2023 17:15
@emhbrine emhbrine changed the title Feature/view metrics refactor Feature: view metrics refactor Oct 13, 2023
@emhbrine emhbrine marked this pull request as ready for review October 13, 2023 17:27
@emhbrine emhbrine requested review from Magnus167, a team and rsueppel as code owners October 13, 2023 17:27
@emhbrine emhbrine merged commit a965407 into develop Oct 16, 2023
3 checks passed
@emhbrine emhbrine deleted the feature/view_metrics_refactor branch October 16, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants