Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom types and isinstance() checks #1069

Merged
merged 29 commits into from
Oct 19, 2023
Merged

Conversation

Magnus167
Copy link
Member

@Magnus167 Magnus167 commented Oct 12, 2023

(Merge in version v0.0.45)
This PR moves some common types from their current subpackages to macrosynergy.management.types to allow for extensive and consistent usage across subpackages.

For reference, intention can be summarized by changes made in PR : #1071

@Magnus167 Magnus167 requested a review from a team as a code owner October 12, 2023 22:50
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1069 (cb0df95) into develop (b62ea1e) will increase coverage by 0.17%.
Report is 6 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head cb0df95 differs from pull request most recent head 60475f6. Consider uploading reports for the commit 60475f6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1069      +/-   ##
===========================================
+ Coverage    64.68%   64.85%   +0.17%     
===========================================
  Files           50       51       +1     
  Lines         5247     5270      +23     
===========================================
+ Hits          3394     3418      +24     
+ Misses        1853     1852       -1     
Files Coverage Δ
macrosynergy/management/__init__.py 100.00% <100.00%> (ø)
macrosynergy/management/types.py 100.00% <100.00%> (ø)
macrosynergy/management/utils.py 91.03% <100.00%> (+0.08%) ⬆️
macrosynergy/visuals/__init__.py 100.00% <100.00%> (ø)
macrosynergy/visuals/common.py 75.96% <100.00%> (-0.83%) ⬇️
macrosynergy/visuals/facetplot.py 59.51% <100.00%> (ø)
macrosynergy/visuals/heatmap.py 72.72% <100.00%> (ø)
macrosynergy/visuals/lineplot.py 60.86% <100.00%> (ø)
macrosynergy/visuals/view/timelines.py 59.79% <100.00%> (ø)

Impacted file tree graph

sandresen1
sandresen1 previously approved these changes Oct 16, 2023
emhbrine
emhbrine previously approved these changes Oct 16, 2023
@Magnus167 Magnus167 dismissed stale reviews from sandresen1 and emhbrine via 1b23c2b October 19, 2023 16:08
@Magnus167 Magnus167 merged commit cb2ed20 into develop Oct 19, 2023
4 checks passed
@Magnus167 Magnus167 deleted the feature/msm-types branch October 19, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants