Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: macrosynergy.visuals, safely failing when "seaborn-darkgrid" style is not available #1075

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

Magnus167
Copy link
Member

No description provided.

@Magnus167 Magnus167 requested a review from a team as a code owner October 13, 2023 16:23
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1075 (9e320a2) into develop (4eb0baf) will increase coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 37.50%.

❗ Current head 9e320a2 differs from pull request most recent head 0de6024. Consider uploading reports for the commit 0de6024 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1075      +/-   ##
===========================================
+ Coverage    65.21%   65.24%   +0.02%     
===========================================
  Files           45       45              
  Lines         5086     5093       +7     
===========================================
+ Hits          3317     3323       +6     
- Misses        1769     1770       +1     
Files Coverage Δ
macrosynergy/visuals/plotter.py 72.52% <37.50%> (-3.67%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 marked this pull request as draft October 16, 2023 12:13
@Magnus167 Magnus167 marked this pull request as ready for review October 16, 2023 12:13
@Magnus167 Magnus167 merged commit 14c3190 into develop Oct 16, 2023
3 checks passed
@Magnus167 Magnus167 deleted the bugfix/seaborn_style branch October 16, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants