Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CI/CD, Pull request QC and directives #1084

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

Magnus167
Copy link
Member

@Magnus167 Magnus167 commented Oct 16, 2023

Pull request titles are essential to conveying version history for features as well as documenting changes. They are also used for generating release notes and developer logs (see #1070).
This PR introduces tests that assert a logical naming convention to PR titles.
This PR also introduces PR directives, which effectively allow the author to block/automatically approve merges depending on another PRs status.

See Docs/Contribution_Guide/Pull_Requests/Merge_Queueing for more info

@Magnus167 Magnus167 requested a review from a team as a code owner October 16, 2023 16:21
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1084 (5148d96) into develop (4a5b03c) will increase coverage by 0.00%.
Report is 4 commits behind head on develop.
The diff coverage is 90.47%.

❗ Current head 5148d96 differs from pull request most recent head c24c549. Consider uploading reports for the commit c24c549 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1084   +/-   ##
========================================
  Coverage    65.31%   65.32%           
========================================
  Files           48       48           
  Lines         5149     5156    +7     
========================================
+ Hits          3363     3368    +5     
- Misses        1786     1788    +2     
Files Coverage Δ
macrosynergy/management/shape_dfs.py 86.22% <90.47%> (-0.65%) ⬇️

Impacted file tree graph

@sandresen1 sandresen1 merged commit 658daf9 into develop Oct 16, 2023
4 checks passed
@sandresen1 sandresen1 deleted the feature/enforce_branch_names branch October 16, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants