Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix lags for correl_matrix #1090

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

emhbrine
Copy link
Contributor

@emhbrine emhbrine commented Oct 17, 2023

If two sets of categories are supplied through xcats and xcats_secondary, lags and lags_secondary should specify lags for these sets respectively. Previously, lags would specify lags for both sets if lags_secondary was empty.

@emhbrine emhbrine changed the title Bugfix: fix lags for correl_matrix Bugfix: fix lags for correl_matrix Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1090 (b85caf7) into develop (7665581) will increase coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head b85caf7 differs from pull request most recent head 5be7518. Consider uploading reports for the commit 5be7518 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1090      +/-   ##
===========================================
+ Coverage    65.32%   65.34%   +0.01%     
===========================================
  Files           48       48              
  Lines         5156     5153       -3     
===========================================
- Hits          3368     3367       -1     
+ Misses        1788     1786       -2     
Files Coverage Δ
macrosynergy/panel/view_correlations.py 67.32% <100.00%> (+0.65%) ⬆️

Impacted file tree graph

@emhbrine emhbrine marked this pull request as ready for review October 17, 2023 12:13
@emhbrine emhbrine requested review from rsueppel and a team as code owners October 17, 2023 12:13
@emhbrine emhbrine merged commit f75b94f into develop Oct 17, 2023
4 checks passed
@emhbrine emhbrine deleted the bugfix/correl_matrix_lags branch October 17, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants