Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Side-effects in qdf_to_ticker_df() util. #1112

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Magnus167
Copy link
Member

qdf_to_ticker_df() was missing df = df.copy()

@Magnus167 Magnus167 requested a review from a team as a code owner October 23, 2023 14:35
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #1112 (7575b7d) into develop (8277203) will decrease coverage by 0.07%.
Report is 19 commits behind head on develop.
The diff coverage is 71.05%.

❗ Current head 7575b7d differs from pull request most recent head 8a70b20. Consider uploading reports for the commit 8a70b20 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1112      +/-   ##
===========================================
- Coverage    64.84%   64.78%   -0.07%     
===========================================
  Files           51       51              
  Lines         5291     5299       +8     
===========================================
+ Hits          3431     3433       +2     
- Misses        1860     1866       +6     
Files Coverage Δ
macrosynergy/management/types.py 100.00% <100.00%> (ø)
macrosynergy/visuals/plotter.py 94.31% <100.00%> (ø)
macrosynergy/management/decorators.py 75.96% <42.85%> (ø)
macrosynergy/management/utils.py 88.58% <75.00%> (-2.46%) ⬇️

Impacted file tree graph

@Magnus167 Magnus167 merged commit eed4265 into develop Oct 23, 2023
4 checks passed
@Magnus167 Magnus167 deleted the bugfix/qdf_to_ticker branch October 23, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants