Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Incorrect version format for development versions #1114

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

Magnus167
Copy link
Member

@Magnus167 Magnus167 commented Oct 23, 2023

Removed extra '.' from non-released version string;
It causes python's inbuilt version parser to use the git-version as the micro version

@Magnus167 Magnus167 requested a review from a team as a code owner October 23, 2023 23:30
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1114 (00d0320) into develop (09c25ce) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 00d0320 differs from pull request most recent head a896414. Consider uploading reports for the commit a896414 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1114   +/-   ##
========================================
  Coverage    64.46%   64.46%           
========================================
  Files           54       54           
  Lines         5465     5465           
========================================
  Hits          3523     3523           
  Misses        1942     1942           

Impacted file tree graph

@Magnus167 Magnus167 merged commit 79c6250 into develop Oct 24, 2023
4 checks passed
@Magnus167 Magnus167 deleted the bugfix/dev_package_version branch October 24, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants