Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add a Required Review Directive to workflow #1120

Merged
merged 33 commits into from
Oct 30, 2023
Merged

Feature: Add a Required Review Directive to workflow #1120

merged 33 commits into from
Oct 30, 2023

Conversation

sandresen1
Copy link
Contributor

@sandresen1 sandresen1 commented Oct 24, 2023 •
edited

@sandresen1 sandresen1 marked this pull request as ready for review October 24, 2023 15:17
@sandresen1 sandresen1 requested a review from a team as a code owner October 24, 2023 15:17
@sandresen1 sandresen1 changed the title Feature/rrd sa Feature: RRD Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited

Codecov Report

Merging #1120 (e9173b6) into develop (dee94b8) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head e9173b6 differs from pull request most recent head e4740b3. Consider uploading reports for the commit e4740b3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1120   +/-   ##
========================================
  Coverage    75.72%   75.72%           
========================================
  Files           56       56           
  Lines         4940     4940           
========================================
  Hits          3741     3741           
  Misses        1199     1199

Impacted file tree graph

Magnus167
Magnus167 previously approved these changes Oct 24, 2023
View reviewed changes
Magnus167
Magnus167 previously approved these changes Oct 24, 2023
View reviewed changes
@sandresen1 sandresen1 changed the title Feature: RRD Feature: Required Review Directive Oct 24, 2023
@Magnus167 Magnus167 changed the title Feature: Required Review Directive Feature Required Review Directive Oct 24, 2023
@sandresen1 sandresen1 changed the title Feature Required Review Directive Feature: Required Review Directive Oct 24, 2023
Magnus167
Magnus167 previously approved these changes Oct 24, 2023
View reviewed changes
Magnus167
Magnus167 previously approved these changes Oct 25, 2023
View reviewed changes
emhbrine
emhbrine previously approved these changes Oct 26, 2023
View reviewed changes
emhbrine
emhbrine previously approved these changes Oct 30, 2023
View reviewed changes
@sandresen1 sandresen1 changed the title Feature: Required Review Directive Feature: Add a Required Review Directive to workflow Oct 30, 2023
@sandresen1 sandresen1 merged commit a34f96d into develop Oct 30, 2023
5 of 7 checks passed
@sandresen1 sandresen1 deleted the feature/rrd_sa branch October 30, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhbrine emhbrine emhbrine approved these changes

@Magnus167 Magnus167 Magnus167 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandresen1 @Magnus167 @emhbrine