Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: make_relative_value(), unintented warning when preparing basket #1158

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

Magnus167
Copy link
Member

No description provided.

@Magnus167 Magnus167 requested review from rsueppel and a team as code owners October 30, 2023 12:53
@Magnus167 Magnus167 linked an issue Oct 30, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1158 (b786724) into develop (1b89bfd) will decrease coverage by 0.15%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head b786724 differs from pull request most recent head 4a5b0f8. Consider uploading reports for the commit 4a5b0f8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1158      +/-   ##
===========================================
- Coverage    75.86%   75.72%   -0.15%     
===========================================
  Files           56       56              
  Lines         4935     4939       +4     
===========================================
- Hits          3744     3740       -4     
- Misses        1191     1199       +8     
Files Coverage Δ
macrosynergy/panel/make_relative_value.py 97.61% <100.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 merged commit 1f71c52 into develop Oct 31, 2023
4 checks passed
@Magnus167 Magnus167 deleted the bugfix/mrv_warns branch October 31, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_relative_value produces unnecessary warning
2 participants