Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fix time_series_check number error #1167

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Bugfix: Fix time_series_check number error #1167

merged 1 commit into from
Nov 1, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners October 31, 2023 18:24
@sandresen1 sandresen1 linked an issue Oct 31, 2023 that may be closed by this pull request
panel_calculator cannot apply pandas methods if name ends on number #1166
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1167 (ba6dca1) into develop (76ce9b5) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head ba6dca1 differs from pull request most recent head 5aa4160. Consider uploading reports for the commit 5aa4160 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1167   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files           58       58           
  Lines         4963     4963           
========================================
  Hits          3771     3771           
  Misses        1192     1192
Files Coverage Δ
macrosynergy/panel/panel_calculator.py 96.80% <100.00%> (ø)

Impacted file tree graph

@sandresen1 sandresen1 merged commit 404bbb3 into develop Nov 1, 2023
4 checks passed
@sandresen1 sandresen1 deleted the bugfix/name_ending_in_number branch November 1, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Magnus167 Magnus167 Magnus167 approved these changes

@rsueppel rsueppel Awaiting requested review from rsueppel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panel_calculator cannot apply pandas methods if name ends on number
2 participants
@sandresen1 @Magnus167