Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: removing max_drawdown metric #1177

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

emhbrine
Copy link
Contributor

@emhbrine emhbrine commented Nov 3, 2023

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1177 (67e741f) into develop (d73023b) will increase coverage by 0.17%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 67e741f differs from pull request most recent head e625600. Consider uploading reports for the commit e625600 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1177      +/-   ##
===========================================
+ Coverage    76.53%   76.71%   +0.17%     
===========================================
  Files           61       61              
  Lines         5072     5059      -13     
===========================================
- Hits          3882     3881       -1     
+ Misses        1190     1178      -12     
Files Coverage Δ
macrosynergy/learning/__init__.py 100.00% <ø> (ø)
macrosynergy/learning/metrics.py 20.83% <ø> (+2.00%) ⬆️

Impacted file tree graph

@emhbrine emhbrine marked this pull request as ready for review November 3, 2023 09:50
@emhbrine emhbrine requested review from rushilg99 and a team as code owners November 3, 2023 09:50
@rushilg99 rushilg99 merged commit 3c86039 into develop Nov 3, 2023
5 checks passed
@rushilg99 rushilg99 deleted the bugfix/max_drawdown branch November 3, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants