Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Clips expected zn scores to prevent occasional false failure on modify signals test #1178

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested a review from a team as a code owner November 3, 2023 11:46
@Magnus167
Copy link
Member

Problem was: Test did not correctly simulate the expected behaviour of thresh param

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1178 (a5fa3e5) into develop (080ffd3) will decrease coverage by 1.86%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head a5fa3e5 differs from pull request most recent head 37fc428. Consider uploading reports for the commit 37fc428 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1178      +/-   ##
===========================================
- Coverage    78.57%   76.71%   -1.86%     
===========================================
  Files           61       61              
  Lines         5059     5059              
===========================================
- Hits          3975     3881      -94     
- Misses        1084     1178      +94     

see 1 file with indirect coverage changes

Impacted file tree graph

@sandresen1 sandresen1 merged commit 54550d5 into develop Nov 3, 2023
4 checks passed
@sandresen1 sandresen1 deleted the bugfix/modify_signals branch November 3, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants