Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add legend location and bbox args to view_ranges() #1212

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

Magnus167
Copy link
Member

This pull request adds the ability to specify the location and bbox of the legend in the view_ranges function. This is achieved by passing the legend_loc and legend_bbox_to_anchor arguments to ax.legend.

Commits included:

  • adding legend loc args and docstrings

  • added loc and bbox_to_anchor pass-through to ax.legend

  • Add legend location and bbox to view_ranges, for pass-through to msv.view_ranges

No issues fixed.

@Magnus167 Magnus167 requested review from a team and rsueppel as code owners November 8, 2023 12:15
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1212 (799a525) into develop (4378a95) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head 799a525 differs from pull request most recent head 26c321e. Consider uploading reports for the commit 26c321e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1212      +/-   ##
===========================================
- Coverage    77.38%   77.36%   -0.02%     
===========================================
  Files           62       62              
  Lines         5252     5253       +1     
===========================================
  Hits          4064     4064              
- Misses        1188     1189       +1     
Files Coverage Δ
macrosynergy/panel/view_ranges.py 88.88% <ø> (ø)
macrosynergy/visuals/ranges.py 12.00% <0.00%> (-0.17%) ⬇️

Impacted file tree graph

mikiinterfiore
mikiinterfiore previously approved these changes Nov 8, 2023
emhbrine
emhbrine previously approved these changes Nov 8, 2023
@Magnus167 Magnus167 merged commit 8c3118a into develop Nov 8, 2023
4 checks passed
@Magnus167 Magnus167 deleted the bugfix/view_ranges_legend_loc branch November 8, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants