Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Consolidate Signal Return Relations and Signals Returns into one single class #1227

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #1227 (24ffaa4) into develop (93722c7) will decrease coverage by 0.16%.
Report is 1 commits behind head on develop.
The diff coverage is 97.05%.

❗ Current head 24ffaa4 differs from pull request most recent head 7ba90ea. Consider uploading reports for the commit 7ba90ea to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1227      +/-   ##
===========================================
- Coverage    77.36%   77.21%   -0.16%     
===========================================
  Files           62       60       -2     
  Lines         5254     5245       -9     
===========================================
- Hits          4065     4050      -15     
- Misses        1189     1195       +6     
Files Coverage Δ
macrosynergy/signal/__init__.py 100.00% <ø> (ø)
macrosynergy/visuals/table.py 100.00% <ø> (ø)
macrosynergy/signal/signal_return_relations.py 96.41% <97.05%> (+1.45%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

Magnus167
Magnus167 previously approved these changes Nov 15, 2023
Magnus167
Magnus167 previously approved these changes Nov 15, 2023
@sandresen1 sandresen1 merged commit 8071076 into develop Nov 15, 2023
4 checks passed
@sandresen1 sandresen1 deleted the feature/consolidate_signals branch November 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants