Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Deprecating singular arguments (ret, sig, freq, agg_sig and rival_sigs) in Signal Return Relations #1235

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Feature: Deprecating singular arguments (ret, sig, freq, agg_sig and rival_sigs) in Signal Return Relations #1235

merged 6 commits into from
Nov 20, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners November 20, 2023 11:32
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited

Codecov Report

Merging #1235 (7db3cce) into develop (4a6755b) will increase coverage by 0.09%.
Report is 1 commits behind head on develop.
The diff coverage is 96.62%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1235      +/-   ##
===========================================
+ Coverage    76.35%   76.44%   +0.09%     
===========================================
  Files           60       60              
  Lines         5349     5370      +21     
===========================================
+ Hits          4084     4105      +21     
  Misses        1265     1265
Files Coverage Δ
macrosynergy/signal/signal_return_relations.py 96.57% <96.62%> (+0.16%) ⬆️

Impacted file tree graph

@sandresen1 sandresen1 changed the title Feature: Deprecating singular arguments in Signal Return Relations Feature: Deprecating singular arguments (ret, sig, freq, agg_sig and rival_sigs) in Signal Return Relations Nov 20, 2023
@sandresen1 sandresen1 merged commit 71c1472 into develop Nov 20, 2023
6 checks passed
@sandresen1 sandresen1 deleted the feature/deprecation_signals branch November 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Magnus167 Magnus167 Magnus167 approved these changes

@rsueppel rsueppel Awaiting requested review from rsueppel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sandresen1 @Magnus167