Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Refactoring historic_vol() #1247

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Feature: Refactoring historic_vol() #1247

merged 9 commits into from
Nov 22, 2023

Conversation

Magnus167
Copy link
Member

This pull request adds date utility functions to the df_utils module and refactors the code to use the get_eops function for trigger indices calculation. It also adds the get_eops function to test_utils.py and refactors the get_cycles function in test_historic_vol.py. These changes improve the efficiency and readability of the codebase.

@Magnus167 Magnus167 requested review from rsueppel and a team as code owners November 22, 2023 12:55
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #1247 (744a07d) into develop (ab1219f) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 84.61%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1247      +/-   ##
===========================================
- Coverage    76.44%   76.43%   -0.01%     
===========================================
  Files           61       61              
  Lines         5362     5382      +20     
===========================================
+ Hits          4099     4114      +15     
- Misses        1263     1268       +5     
Files Coverage Δ
macrosynergy/management/utils/__init__.py 100.00% <ø> (ø)
macrosynergy/panel/historic_vol.py 97.40% <86.66%> (+0.59%) ⬆️
macrosynergy/management/utils/df_utils.py 93.95% <83.78%> (-1.29%) ⬇️

Impacted file tree graph

@Magnus167 Magnus167 merged commit 93f6d95 into develop Nov 22, 2023
5 of 6 checks passed
@Magnus167 Magnus167 deleted the refactor/hist_vol branch November 22, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants