Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Removes incorrect assert from update_df and add more robust tests #1250

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested a review from a team as a code owner November 23, 2023 11:36
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1250 (731d70c) into develop (600bf99) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 731d70c differs from pull request most recent head 89bc2e7. Consider uploading reports for the commit 89bc2e7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1250   +/-   ##
========================================
  Coverage    76.48%   76.49%           
========================================
  Files           61       61           
  Lines         5379     5381    +2     
========================================
+ Hits          4114     4116    +2     
  Misses        1265     1265           
Files Coverage Δ
macrosynergy/management/utils/df_utils.py 93.99% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 merged commit 740b47e into develop Nov 23, 2023
4 checks passed
@Magnus167 Magnus167 deleted the bugfix/remove_incorrect_assert branch November 23, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants