Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: When cross sections intersections exclusively across signals are empty the communal sample doesn't index from the dataframe #1261

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

across signals are empty the communal sample
doesn't index from the dataframe
@sandresen1 sandresen1 requested review from rsueppel and a team as code owners November 24, 2023 17:30
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #1261 (c51fafa) into develop (1f9e6ca) will increase coverage by 0.54%.
Report is 1 commits behind head on develop.
The diff coverage is 83.33%.

❗ Current head c51fafa differs from pull request most recent head 04e042e. Consider uploading reports for the commit 04e042e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1261      +/-   ##
===========================================
+ Coverage    75.62%   76.17%   +0.54%     
===========================================
  Files           61       61              
  Lines         5445     5406      -39     
===========================================
  Hits          4118     4118              
+ Misses        1327     1288      -39     
Files Coverage Δ
macrosynergy/signal/signal_return_relations.py 96.37% <83.33%> (-0.20%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

@sandresen1 sandresen1 merged commit 582289b into develop Nov 27, 2023
4 checks passed
@sandresen1 sandresen1 deleted the bugfix/communal_sample_bug branch November 27, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants