Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Ensure negation of signals is reverted #1291

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

sandresen1
Copy link
Contributor

after calculations

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners December 4, 2023 11:47
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1291 (d24331d) into develop (dd1087d) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head d24331d differs from pull request most recent head 7d0ea66. Consider uploading reports for the commit 7d0ea66 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1291   +/-   ##
========================================
  Coverage    74.24%   74.25%           
========================================
  Files           62       62           
  Lines         5548     5550    +2     
========================================
+ Hits          4119     4121    +2     
  Misses        1429     1429           
Files Coverage Δ
macrosynergy/signal/signal_return_relations.py 96.39% <100.00%> (+0.01%) ⬆️

Impacted file tree graph

@sandresen1 sandresen1 merged commit d86aacc into develop Dec 4, 2023
4 checks passed
@sandresen1 sandresen1 deleted the bugfix/revert_negation branch December 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants