Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Reverts negation of signal on instantiation of Signal Return Relations #1310

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners December 11, 2023 12:19
emhbrine
emhbrine previously approved these changes Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1310 (c12d7ed) into develop (b0b255a) will increase coverage by 0.07%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1310      +/-   ##
===========================================
+ Coverage    73.49%   73.57%   +0.07%     
===========================================
  Files           62       62              
  Lines         5683     5684       +1     
===========================================
+ Hits          4177     4182       +5     
+ Misses        1506     1502       -4     
Files Coverage Δ
macrosynergy/signal/signal_return_relations.py 87.97% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

@sandresen1 sandresen1 merged commit 34fd27d into develop Dec 11, 2023
6 checks passed
@sandresen1 sandresen1 deleted the bugfix/reverting_negation branch December 11, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants