Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: speed up learning tests #1343

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Feature: speed up learning tests #1343

merged 2 commits into from
Jan 2, 2024

Conversation

emhbrine
Copy link
Contributor

@emhbrine emhbrine commented Dec 31, 2023

Using setUpClass instead of setUp in unit tests so that the setup is done once per class rather than before each test. This is especially important for TestMapSelector since using MixedLM is expensive.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77b0edc) 78.80% compared to head (46aab8d) 78.28%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1343      +/-   ##
===========================================
- Coverage    78.80%   78.28%   -0.53%     
===========================================
  Files           62       62              
  Lines         5762     5762              
===========================================
- Hits          4541     4511      -30     
- Misses        1221     1251      +30     

see 3 files with indirect coverage changes

Impacted file tree graph

@emhbrine emhbrine marked this pull request as ready for review January 2, 2024 11:36
@emhbrine emhbrine requested a review from a team as a code owner January 2, 2024 11:36
@emhbrine emhbrine merged commit 33dccde into develop Jan 2, 2024
11 of 12 checks passed
@emhbrine emhbrine deleted the feature/learning_tests branch January 2, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants