Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Change legend location to appear below the plot to prevent squashing of the graph and stop overwriting of the variable legend_loc #1349

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners January 2, 2024 11:33
@sandresen1 sandresen1 changed the title Bugfix/legend loc Bugfix: Change legend location to appear below the plot to prevent squashing of the graph and stop overwriting of the variable legend_loc Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (46aab8d) 78.28% compared to head (fcdd9ea) 78.74%.
Report is 1 commits behind head on develop.

❗ Current head fcdd9ea differs from pull request most recent head 053ddbe. Consider uploading reports for the commit 053ddbe to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1349      +/-   ##
===========================================
+ Coverage    78.28%   78.74%   +0.45%     
===========================================
  Files           62       62              
  Lines         5762     5767       +5     
===========================================
+ Hits          4511     4541      +30     
+ Misses        1251     1226      -25     
Files Coverage Δ
macrosynergy/panel/view_ranges.py 57.14% <0.00%> (-31.75%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

@sandresen1 sandresen1 merged commit e19b12b into develop Jan 2, 2024
9 checks passed
@sandresen1 sandresen1 deleted the bugfix/legend_loc branch January 2, 2024 11:46
@sandresen1 sandresen1 linked an issue Jan 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macrosynergy.panel.view_ranges default legend should be bottom.
2 participants