Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: signal optimiser unit tests, error handling and rolling option #1373

Merged
merged 26 commits into from
Jan 11, 2024

Conversation

rushilg99
Copy link
Contributor

No description provided.

@rushilg99 rushilg99 marked this pull request as ready for review January 5, 2024 18:04
@rushilg99 rushilg99 requested a review from a team as a code owner January 5, 2024 18:04
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd992cf) 78.75% compared to head (74af043) 81.09%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1373      +/-   ##
===========================================
+ Coverage    78.75%   81.09%   +2.33%     
===========================================
  Files           62       62              
  Lines         5786     5797      +11     
===========================================
+ Hits          4557     4701     +144     
+ Misses        1229     1096     -133     
Files Coverage Δ
macrosynergy/learning/signal_optimizer.py 98.72% <100.00%> (+57.39%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

emhbrine
emhbrine previously approved these changes Jan 8, 2024
@rushilg99 rushilg99 changed the title Feature: signal optimiser unit tests Feature: signal optimiser unit tests, error handling and rolling option Jan 11, 2024
@rushilg99 rushilg99 merged commit 521eb60 into develop Jan 11, 2024
7 checks passed
@rushilg99 rushilg99 deleted the feature/so_tests branch January 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants