Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Fix datetime.datetime.utcnow() usage #1393

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

Magnus167
Copy link
Member

This pull request fixes the import and usage of UTC datetime in the code. It replaces the usage of datetime.utcnow() with datetime.now(datetime_UTC), as stated in deprecation warnings.

@Magnus167 Magnus167 requested a review from a team as a code owner January 17, 2024 10:11
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a9c468) 82.25% compared to head (0b6cdb9) 82.18%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1393      +/-   ##
===========================================
- Coverage    82.25%   82.18%   -0.07%     
===========================================
  Files           60       60              
  Lines         5916     5917       +1     
===========================================
- Hits          4866     4863       -3     
- Misses        1050     1054       +4     
Files Coverage Δ
macrosynergy/download/dataquery.py 71.69% <100.00%> (+0.08%) ⬆️
macrosynergy/download/jpmaqs.py 84.46% <ø> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 merged commit 7d250ed into develop Jan 30, 2024
6 of 7 checks passed
@Magnus167 Magnus167 deleted the feature/remove_utcnow branch January 30, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants