Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updating delay param code #1412

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

Magnus167
Copy link
Member

@Magnus167 Magnus167 commented Jan 23, 2024

Lowering the delay parameter below 200ms only throws an Runtime Warnings now, whereas it would throw a ValueError earlier.
In cases where a request fails and the request_wrapper() does a retry, the default API_DELAY_PARAM (300ms) will be used (the user cannot edit this.

Use as:

with JPMaQSDownload(..., dq_download_kwargs={"delay_param" : 0.1}) ...

@Magnus167 Magnus167 requested a review from a team as a code owner January 23, 2024 12:10
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b413af) 82.28% compared to head (7953448) 82.29%.
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1412   +/-   ##
========================================
  Coverage    82.28%   82.29%           
========================================
  Files           60       60           
  Lines         5905     5907    +2     
========================================
+ Hits          4859     4861    +2     
  Misses        1046     1046           
Files Coverage Δ
macrosynergy/download/dataquery.py 71.60% <100.00%> (+0.18%) ⬆️

Impacted file tree graph

@Magnus167 Magnus167 merged commit 56091a9 into develop Jan 23, 2024
7 checks passed
@Magnus167 Magnus167 deleted the feature/update_delay_param_logic branch January 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants