Feature: BaseWeightedLinearRegression #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhbrine
force-pushed
the
feature/weighted_regression
branch
from
4ae629c
to
d637aaf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1431 +/- ##
===========================================
- Coverage 82.07% 82.05% -0.03%
===========================================
Files 59 59
Lines 5920 5906 -14
===========================================
- Hits 4859 4846 -13
+ Misses 1061 1060 -1
|
rushilg99
previously approved these changes
Feb 2, 2024
emhbrine
force-pushed
the
feature/weighted_regression
branch
2 times, most recently
from
12f814f
to
1ad88bc
Compare
emhbrine
force-pushed
the
feature/weighted_regression
branch
from
1ad88bc
to
e31a926
Compare
rushilg99
reviewed
Feb 2, 2024
macrosynergy/learning/predictors.py
Outdated
| into the constructor. | ||
|
|
||
| :param <pd.DataFrame> X: Pandas dataframe of input features. | ||
| :param <Union[pd.DataFrame, pd.Series]> y: Pandas series or dataframe of targets | ||
| associated with each sample in X. | ||
|
|
||
| :return <SignWeightedRegressor> | ||
| :return <BaseWeightedLinearRegression> |
There was a problem hiding this comment.
This should return an instance of BaseWeightedRegressor not BaseWeightedLinearRegression right?
rushilg99
previously approved these changes
Feb 2, 2024
Magnus167
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.