Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correct logging level for DQ paginated responses #1439

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Magnus167
Copy link
Member

This pull request updates the logger.info statement to logger.debug in the DataQueryInterface class for handling paginated responses. This change improves the logging level and provides prevents excess information in scripts or stdout

@Magnus167 Magnus167 requested a review from a team as a code owner February 2, 2024 04:07
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (55d35da) 81.89% compared to head (93019cf) 81.78%.
Report is 1 commits behind head on develop.

❗ Current head 93019cf differs from pull request most recent head 03daa84. Consider uploading reports for the commit 03daa84 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1439      +/-   ##
===========================================
- Coverage    81.89%   81.78%   -0.12%     
===========================================
  Files           59       59              
  Lines         6011     6007       -4     
===========================================
- Hits          4923     4913      -10     
- Misses        1088     1094       +6     
Files Coverage Δ
macrosynergy/download/dataquery.py 71.60% <0.00%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 merged commit 96344ff into develop Feb 5, 2024
5 checks passed
@Magnus167 Magnus167 deleted the bugfix/log_level_paginations branch February 5, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants