Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Added reversible mapping for _map_to_business_day_frequency #1446

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

Magnus167
Copy link
Member

This pull request adds a reverse mapping functionality for the _map_to_business_day_frequency function. It also includes test cases for the function.

@Magnus167 Magnus167 requested a review from a team as a code owner February 5, 2024 16:14
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (9e3e957) 82.09% compared to head (55d35da) 81.89%.
Report is 23 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1446      +/-   ##
===========================================
- Coverage    82.09%   81.89%   -0.20%     
===========================================
  Files           59       59              
  Lines         5909     6011     +102     
===========================================
+ Hits          4851     4923      +72     
- Misses        1058     1088      +30     
Files Coverage Δ
macrosynergy/download/dataquery.py 71.60% <100.00%> (ø)
macrosynergy/download/jpmaqs.py 85.27% <100.00%> (+0.29%) ⬆️
macrosynergy/learning/__init__.py 100.00% <ø> (ø)
macrosynergy/learning/signal_optimizer.py 98.72% <100.00%> (ø)
macrosynergy/learning/transformers.py 92.27% <100.00%> (ø)
macrosynergy/management/utils/__init__.py 100.00% <ø> (ø)
...acrosynergy/management/utils/check_availability.py 61.70% <ø> (ø)
macrosynergy/management/utils/core.py 94.57% <100.00%> (+5.59%) ⬆️
macrosynergy/management/utils/df_utils.py 93.86% <100.00%> (-0.13%) ⬇️
macrosynergy/panel/basket.py 83.59% <ø> (ø)
... and 10 more

Impacted file tree graph

@Magnus167 Magnus167 merged commit 0e36f1b into develop Feb 5, 2024
6 of 7 checks passed
@Magnus167 Magnus167 deleted the bugfix/freq_bfreq_map branch February 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants