Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add unit tests for VintageData class #1448

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

Magnus167
Copy link
Member

This pull request adds unit tests for the VintageData class in the simulate module. The tests cover the make_grade1, make_grade2, and make_graded methods, ensuring that the generated dataframes have the expected structure and values.

@Magnus167 Magnus167 requested a review from a team as a code owner February 5, 2024 19:55
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34c182f) 81.89% compared to head (8a140f2) 83.77%.
Report is 1 commits behind head on develop.

❗ Current head 8a140f2 differs from pull request most recent head ef1c3f5. Consider uploading reports for the commit ef1c3f5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1448      +/-   ##
===========================================
+ Coverage    81.89%   83.77%   +1.87%     
===========================================
  Files           59       59              
  Lines         6011     6011              
===========================================
+ Hits          4923     5036     +113     
+ Misses        1088      975     -113     
Files Coverage Δ
...nergy/management/simulate/simulate_vintage_data.py 97.05% <100.00%> (+83.08%) ⬆️

Impacted file tree graph

@Magnus167 Magnus167 merged commit 28f15eb into develop Feb 6, 2024
5 checks passed
@Magnus167 Magnus167 deleted the feature/vintage_data_tests branch February 6, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants