Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Signal optimiser edge case handling for no model selected + blacklisted country not in the dataframe #1452

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

rushilg99
Copy link
Contributor

No description provided.

@rushilg99 rushilg99 requested a review from a team as a code owner February 6, 2024 17:52
rsueppel
rsueppel previously approved these changes Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2bbd60c) 83.81% compared to head (b35796f) 83.77%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1452      +/-   ##
===========================================
- Coverage    83.81%   83.77%   -0.04%     
===========================================
  Files           59       59              
  Lines         6048     6053       +5     
===========================================
+ Hits          5069     5071       +2     
- Misses         979      982       +3     
Files Coverage Δ
macrosynergy/learning/signal_optimizer.py 97.50% <66.66%> (-1.23%) ⬇️

Impacted file tree graph

@rushilg99 rushilg99 merged commit a2fd418 into develop Feb 7, 2024
6 of 7 checks passed
@rushilg99 rushilg99 deleted the feature/so_improvements branch February 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants