Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: JPMaQSDownload, adding more log statements #1484

Merged
merged 10 commits into from Feb 22, 2024

Conversation

Magnus167
Copy link
Member

No description provided.

@Magnus167 Magnus167 requested a review from a team as a code owner February 21, 2024 10:07
sandresen1
sandresen1 previously approved these changes Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3cc5e88) 85.86% compared to head (791bf7c) 85.95%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1484      +/-   ##
===========================================
+ Coverage    85.86%   85.95%   +0.08%     
===========================================
  Files           60       60              
  Lines         6226     6250      +24     
===========================================
+ Hits          5346     5372      +26     
+ Misses         880      878       -2     
Files Coverage Δ
macrosynergy/download/dataquery.py 98.25% <100.00%> (+<0.01%) ⬆️
macrosynergy/management/types.py 97.29% <100.00%> (+0.07%) ⬆️
macrosynergy/download/jpmaqs.py 99.40% <90.90%> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

@Magnus167 Magnus167 merged commit 4f2c63f into develop Feb 22, 2024
7 checks passed
@Magnus167 Magnus167 deleted the bugfix/jpmaqs_download branch February 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants