Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: CategoryRelations docstrings #1541

Merged
merged 3 commits into from
Mar 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions macrosynergy/panel/category_relations.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class CategoryRelations(object):
Importantly, for analysis with explanatory and dependent categories, the second
takes the role of the dependent and a forward window means that the dependent
values average forward into the future.
:param: <List[float]> xcat_trims: two-element list with maximum absolute values
:param <List[float]> xcat_trims: two-element list with maximum absolute values
for the two respective categories. Observations with higher values will be
trimmed, i.e. removed from the analysis (not winsorized!). Default is None
for both. Trimming is applied after all other transformations.
Expand Down Expand Up @@ -808,7 +808,7 @@ def ols_table(self, type="pool"):

# Reduced DataFrame.
dfdx = dfd[~(filt1 | filt2)].copy()
dfdx["ERA"]: str = "before 2007"
dfdx["ERA"] = "before 2007"
dfdx.loc[dfdx["real_date"].dt.year > 2007, "ERA"] = "from 2010"

cidx = ["AUD", "CAD", "GBP", "USD", "PRY"]
Expand Down