basket.py #262
basket.py #262
Conversation
|
Intermediary stage. |
|
Believe code is complete - requires testing. |
|
Initial testing complete. |
|
Transitioning on to the Unit Test redesign. |
|
Intermediary commit - will potentially fail. |
|
Unit Test complete assuming there are not any hidden bugs. |
|
Changes made to make_relative_value unit test can be ignored. |
|
Target Positions is nearing completion. |
|
Following discussions / comments - changes are required to target_positions.py |
|
basket.py complete. |
|
target_positions.py complete. Will require an extensive Unit Test. |
Feature/basket single
|
Latest version of Basket.py file required for target_positions. Merged the pull requests. |
Small changes and todos to Target Positions.
|
Final changes to unit_target_positions being made. |
|
Work complete following ToDo assignments. |
| assert isinstance(df_c_wgts, (list, pd.DataFrame)), error_4 | ||
|
|
||
| basket_names = [] | ||
| ctypes_baskets = ctypes + basket_names |
There was a problem hiding this comment.
This is equivalent to ctypes_baskets = ctypes.
|
|
||
| basket_names = [] | ||
| ctypes_baskets = ctypes + basket_names | ||
| if baskets: |
There was a problem hiding this comment.
baskets is of type baskets: dict = None, not bool
Development & completion of Basket Class.