Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/naive_pnl #300

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Feature/naive_pnl #300

merged 3 commits into from
Mar 31, 2022

Conversation

Ksteeds
Copy link
Contributor

@Ksteeds Ksteeds commented Mar 30, 2022

Believe naive_pnl work complete - integration of make_zn_scores(). Requires confirmation.

@Ksteeds Ksteeds self-assigned this Mar 30, 2022
@Ksteeds Ksteeds linked an issue Mar 30, 2022 that may be closed by this pull request
NaivePnL/ make_pnl: implement pass-through arguments #299
Closed
@rsueppel rsueppel self-requested a review March 31, 2022 11:16
@rsueppel rsueppel merged commit ae94d0f into develop Mar 31, 2022
@rsueppel rsueppel deleted the feature/naive_pnl branch March 31, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsueppel rsueppel rsueppel approved these changes

Assignees

@Ksteeds Ksteeds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NaivePnL/ make_pnl: implement pass-through arguments
2 participants
@Ksteeds @rsueppel