reg_scatter issues #317
Merged
reg_scatter issues #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…graph Feature/category relations graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still two issues to solve.
[1] the separator='cids' option does not plot the correct regplots but rather the same regplot for all cross sections. You need a wide dataframe to solve this, I think. See Todo line 375
[2] the separator= works but the presentation of the table is not for publication. Rather than two different tables, please create a single one, with two rows and simply assign the color of the periods to the color of font or background of the numbers, with first (oldest) period being in first row. Also, font size should be same as single table.