make_zn_score: Docs changes and Todos #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ksteeds
reviewed
May 22, 2022
| @@ -389,6 +410,8 @@ def make_zn_scores(df: pd.DataFrame, xcat: str, cids: List[str] = None, | |||
|
|
|||
| if est_freq != "d": | |||
| dfw = dfw.resample(pd_freq[est_freq], axis=0, convention='end').last() | |||
| # Todo: Fatal bug. This means subsequent applications of pen_neutral etc. | |||
There was a problem hiding this comment.
Is this not the purpose ? To calculate the neutral levels and standard deviations on a lower frequency. For instance, an assert that has a low variance which will subsequently not fluctuate a considerable amount over a week.
Ksteeds
reviewed
May 22, 2022
|
|
||
| elif sequential and iis: | ||
| iis_neutral = np.repeat(df.iloc[0:min_obs].stack().mean(), | ||
| min_obs) | ||
|
|
||
| os_neutral = rolling_mean_with_nan(dfw=df) | ||
| # Todo: incorrect, use pandas df.expanding.mean() |
There was a problem hiding this comment.
Why incorrect ? I'm not sure df.expanding.mean() works when computing a rolling mean across a panel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.