Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/dq_oauth #361

Merged
merged 20 commits into from
Jun 1, 2022
Merged

feature/dq_oauth #361

merged 20 commits into from
Jun 1, 2022

Conversation

Ksteeds
Copy link
Contributor

@Ksteeds Ksteeds commented May 27, 2022

OAuth.

Still requires testing and integration into DQ.py file.

@Ksteeds Ksteeds requested a review from rsueppel May 27, 2022 11:02
@Ksteeds Ksteeds self-assigned this May 27, 2022
@Ksteeds
Copy link
Contributor Author

Ksteeds commented May 27, 2022

Requires testing.

Broad design complete.

@lsimonsen
Copy link
Member

As discussed @Ksteeds here is the propose re-working of the folder structure for the DataQuery interface:

  • macrosynergy
    • dataquery
      • api.py
        • Interface class
      • auth.py
        • OAuth class for OAuth authentication
        • CertAuth class for certificate authentication

To keep back-ward compatibility we can rework the current DataQuery interface file dq.py into:

import warnings
from ..dataquery.api import Interface as DataQueryInterface

warnings.warn(
    "DataQueryInterface has been moved to macrosynergy.dataquery.api"
   DeprecationWArning,
   stacklevel=2
)

__all__ = ["DataQueryInterface"]

This should insure old code will still work.

macrosynergy/management/OAuth_connection.py Outdated Show resolved Hide resolved
macrosynergy/management/OAuth_connection.py Outdated Show resolved Hide resolved
macrosynergy/management/OAuth_connection.py Outdated Show resolved Hide resolved
macrosynergy/management/OAuth_connection.py Outdated Show resolved Hide resolved
macrosynergy/management/OAuth_connection.py Outdated Show resolved Hide resolved
macrosynergy/management/OAuth_connection.py Outdated Show resolved Hide resolved
macrosynergy/management/dq.py Outdated Show resolved Hide resolved
macrosynergy/management/dq.py Outdated Show resolved Hide resolved
macrosynergy/management/dq.py Outdated Show resolved Hide resolved
macrosynergy/management/dq.py Outdated Show resolved Hide resolved
@Ksteeds Ksteeds requested a review from lsimonsen May 31, 2022 11:54
Copy link
Member

@lsimonsen lsimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition we need to move cert_auth.py and oauth.py into a single file named auth.py to keep it simple.

macrosynergy/dataquery/oauth.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/oauth.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/oauth.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/oauth.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/oauth.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/api.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/api.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/api.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/api.py Outdated Show resolved Hide resolved
macrosynergy/dataquery/api.py Outdated Show resolved Hide resolved
@lsimonsen lsimonsen merged commit fd16d8c into develop Jun 1, 2022
@Ksteeds Ksteeds deleted the feature/dq_oauth branch June 6, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants