Ralph simplifies make_zn_scores #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified make_zn_score and gathered all expanding means and mean absolute values into one function. The shorted the code from 550 to 180 lines (<50 lines excluding docstrings)
However, even the present code is still fairly long for careful reviews for a function whose correctness is essential for our business. Moreover, I have done very little testing. So I am sure there are bigs and errors left.
Therefore, unit testing must focus on double-calculating values and check if they are as expected.
In particular, please use pandas .expanding() function to check out calculations for specific columns and re-estimation dates.