Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/panel_calculator #410

Merged
merged 2 commits into from
Jul 7, 2022
Merged

bugfix/panel_calculator #410

merged 2 commits into from
Jul 7, 2022

Conversation

Ksteeds
Copy link
Contributor

@Ksteeds Ksteeds commented Jul 5, 2022

Subtle bug.

@Ksteeds Ksteeds requested a review from rsueppel July 5, 2022 11:47
@Ksteeds Ksteeds self-assigned this Jul 5, 2022
@Ksteeds
Copy link
Contributor Author

Ksteeds commented Jul 5, 2022

Believe the origination of the intersection bug is caused by:

dfx = reduce_df(df, xcats=old_xcats_used, cids=cids,
                start=start, end=end, blacklist=blacklist,
                intersect=True)

@Ksteeds Ksteeds linked an issue Jul 5, 2022 that may be closed by this pull request
msp.panel_calculator: incomplete output frame #406
Closed
@Ksteeds
Copy link
Contributor Author

Ksteeds commented Jul 5, 2022

Believe second bug regarding a category ending with a digit has also been resolved.

@Ksteeds Ksteeds merged commit 0022022 into develop Jul 7, 2022
@lsimonsen lsimonsen deleted the bugfix/panel_calculator branch October 10, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsueppel rsueppel rsueppel approved these changes

Assignees

@Ksteeds Ksteeds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msp.panel_calculator: incomplete output frame
2 participants
@Ksteeds @rsueppel