feature/multiple_signals #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
First proposal is complete. |
Ksteeds
commented
Jul 18, 2022
macrosynergy/signal/signal_return.py
Outdated
|
|
||
| df_sigs = self.__signal_table__(df=dfd, sigs=rival_sigs, xcats=xcats, | ||
| agg_sig=agg_sig) | ||
| # Todo: dfd has nor reference, should this be df? |
There was a problem hiding this comment.
Typo - should be "df". Problem with Python that it will still reference the variable from the parent scope, as opposed to the locally passed DataFrame.
|
Update of Unit Test still required. |
signal_return: partial review and TODOs
rsueppel
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: add method .rival_sigs(sigs, sig_neg: bool = False)
In this case a comparative output table is returned with the Panel
row of the original table only, but for the original signal and
all rival categories.